FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux General Discussion

 
 
LinkBack Thread Tools
 
Old 06-28-2010, 04:29 PM
Radek Vykydal
 
Default Don't deactivate active device before running nm-c-e (#608773)

Due to ifcfg file being removed before writing updated one,
the connection is deactivated unconditionally, which is bad.
It happened with devices activated in stage 1.
---
simpleconfig.py | 8 +-------
1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/simpleconfig.py b/simpleconfig.py
index 23fcaaa..a51ce6c 100644
--- a/simpleconfig.py
+++ b/simpleconfig.py
@@ -125,8 +125,7 @@ class IfcfgFile(SimpleConfigFile):
return len(self.info)

# This method has to write file in a particular
- # way so that ifcfg-rh's inotify mechanism triggeres
- # TODORV: check that it is still true.
+ # way so that ifcfg-rh's inotify mechanism is triggered.
def write(self, dir=None):
"""Writes values into ifcfg file."""

@@ -140,10 +139,5 @@ class IfcfgFile(SimpleConfigFile):
os.close(fd)

os.chmod(newifcfg, 0644)
- try:
- os.remove(path)
- except OSError, e:
- if e.errno != 2:
- raise
shutil.move(newifcfg, path)

--
1.6.0.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 06-29-2010, 11:43 AM
Radek Vykydal
 
Default Don't deactivate active device before running nm-c-e (#608773)

Please ignore, I'm going to post better patch.

Radek

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 01:51 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org