FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux General Discussion

 
 
LinkBack Thread Tools
 
Old 03-17-2010, 07:06 PM
David Lehman
 
Default Don't pass size=1 for autopart PVs. Use PartitionDevice's default size.

Also avoid putting size=1 in anaconda-ks.cfg for partitions.
---
storage/devices.py | 2 +-
storage/partitioning.py | 1 -
2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/storage/devices.py b/storage/devices.py
index dededb8..14e136f 100644
--- a/storage/devices.py
+++ b/storage/devices.py
@@ -1023,7 +1023,7 @@ class PartitionDevice(StorageDevice):
if self.req_primary:
args.append("--asprimary")
if self.req_size:
- args.append("--size=%s" % (self.req_size or 1))
+ args.append("--size=%s" % (self.req_size or 500))
if preexisting:
if len(self.req_disks) == 1:
args.append("--ondisk=%s" % self.req_disks[0].name)
diff --git a/storage/partitioning.py b/storage/partitioning.py
index 939cf96..bbc5ef6 100644
--- a/storage/partitioning.py
+++ b/storage/partitioning.py
@@ -73,7 +73,6 @@ def _createFreeSpacePartitions(anaconda):
fmt_args = {}
part = anaconda.storage.newPartition(fmt_type=fmt_type,
fmt_args=fmt_args,
- size=1,
grow=True,
disks=[disk])
anaconda.storage.createDevice(part)
--
1.6.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-17-2010, 07:28 PM
Hans de Goede
 
Default Don't pass size=1 for autopart PVs. Use PartitionDevice's default size.

Ack.

On 03/17/2010 09:06 PM, David Lehman wrote:

Also avoid putting size=1 in anaconda-ks.cfg for partitions.
---
storage/devices.py | 2 +-
storage/partitioning.py | 1 -
2 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/storage/devices.py b/storage/devices.py
index dededb8..14e136f 100644
--- a/storage/devices.py
+++ b/storage/devices.py
@@ -1023,7 +1023,7 @@ class PartitionDevice(StorageDevice):
if self.req_primary:
args.append("--asprimary")
if self.req_size:
- args.append("--size=%s" % (self.req_size or 1))
+ args.append("--size=%s" % (self.req_size or 500))
if preexisting:
if len(self.req_disks) == 1:
args.append("--ondisk=%s" % self.req_disks[0].name)
diff --git a/storage/partitioning.py b/storage/partitioning.py
index 939cf96..bbc5ef6 100644
--- a/storage/partitioning.py
+++ b/storage/partitioning.py
@@ -73,7 +73,6 @@ def _createFreeSpacePartitions(anaconda):
fmt_args = {}
part = anaconda.storage.newPartition(fmt_type=fmt_type,
fmt_args=fmt_args,
- size=1,
grow=True,
disks=[disk])
anaconda.storage.createDevice(part)


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-22-2010, 02:34 PM
David Lehman
 
Default Don't pass size=1 for autopart PVs. Use PartitionDevice's default size.

Also avoid putting size=1 in anaconda-ks.cfg for partitions.
---
storage/devices.py | 5 +++--
storage/partitioning.py | 1 -
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/storage/devices.py b/storage/devices.py
index dededb8..6fe7d90 100644
--- a/storage/devices.py
+++ b/storage/devices.py
@@ -870,6 +870,7 @@ class PartitionDevice(StorageDevice):
"""
_type = "partition"
_resizable = True
+ defaultSize = 500

def __init__(self, name, format=None,
size=None, grow=False, maxsize=None,
@@ -958,7 +959,7 @@ class PartitionDevice(StorageDevice):
# for new partitions.
if not self._size:
# default size for new partition requests
- self._size = 500
+ self._size = self.defaultSize
self.req_name = name
self.req_partType = partType
self.req_primary = primary
@@ -1023,7 +1024,7 @@ class PartitionDevice(StorageDevice):
if self.req_primary:
args.append("--asprimary")
if self.req_size:
- args.append("--size=%s" % (self.req_size or 1))
+ args.append("--size=%s" % (self.req_size or self.defaultSize))
if preexisting:
if len(self.req_disks) == 1:
args.append("--ondisk=%s" % self.req_disks[0].name)
diff --git a/storage/partitioning.py b/storage/partitioning.py
index 939cf96..bbc5ef6 100644
--- a/storage/partitioning.py
+++ b/storage/partitioning.py
@@ -73,7 +73,6 @@ def _createFreeSpacePartitions(anaconda):
fmt_args = {}
part = anaconda.storage.newPartition(fmt_type=fmt_type,
fmt_args=fmt_args,
- size=1,
grow=True,
disks=[disk])
anaconda.storage.createDevice(part)
--
1.6.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-22-2010, 02:53 PM
Hans de Goede
 
Default Don't pass size=1 for autopart PVs. Use PartitionDevice's default size.

Ack.

On 03/22/2010 04:34 PM, David Lehman wrote:

Also avoid putting size=1 in anaconda-ks.cfg for partitions.
---
storage/devices.py | 5 +++--
storage/partitioning.py | 1 -
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/storage/devices.py b/storage/devices.py
index dededb8..6fe7d90 100644
--- a/storage/devices.py
+++ b/storage/devices.py
@@ -870,6 +870,7 @@ class PartitionDevice(StorageDevice):
"""
_type = "partition"
_resizable = True
+ defaultSize = 500

def __init__(self, name, format=None,
size=None, grow=False, maxsize=None,
@@ -958,7 +959,7 @@ class PartitionDevice(StorageDevice):
# for new partitions.
if not self._size:
# default size for new partition requests
- self._size = 500
+ self._size = self.defaultSize
self.req_name = name
self.req_partType = partType
self.req_primary = primary
@@ -1023,7 +1024,7 @@ class PartitionDevice(StorageDevice):
if self.req_primary:
args.append("--asprimary")
if self.req_size:
- args.append("--size=%s" % (self.req_size or 1))
+ args.append("--size=%s" % (self.req_size or self.defaultSize))
if preexisting:
if len(self.req_disks) == 1:
args.append("--ondisk=%s" % self.req_disks[0].name)
diff --git a/storage/partitioning.py b/storage/partitioning.py
index 939cf96..bbc5ef6 100644
--- a/storage/partitioning.py
+++ b/storage/partitioning.py
@@ -73,7 +73,6 @@ def _createFreeSpacePartitions(anaconda):
fmt_args = {}
part = anaconda.storage.newPartition(fmt_type=fmt_type,
fmt_args=fmt_args,
- size=1,
grow=True,
disks=[disk])
anaconda.storage.createDevice(part)


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 12:00 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org