FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Development

 
 
LinkBack Thread Tools
 
Old 05-04-2012, 05:33 PM
Will Woods
 
Default dracut: fix "repo=cdrom" (also kickstart with "cdrom")

The replacement hack for splitsep wasn't detecting the case where the
repo is just "cdrom" - no ":PATH" at the end - and trying to remove the
"cdrom:" from the front of "cdrom", which doesn't work.

In that case, we'll end up with $rest = $repo, so check for that, and
set rest="".
---
dracut/parse-anaconda-repo.sh | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/dracut/parse-anaconda-repo.sh b/dracut/parse-anaconda-repo.sh
index 1e23c36..59bf7b5 100755
--- a/dracut/parse-anaconda-repo.sh
+++ b/dracut/parse-anaconda-repo.sh
@@ -13,7 +13,8 @@ arg="repo"

if [ -n "$repo" ]; then
#splitsep ":" "$repo" repotype rest # FIXME: splitsep is buggy
- repotype=${repo%%:*}; rest=${repo#$repotype:}
+ repotype=${repo%%:*}
+ rest=${repo#$repotype:}; [ "$rest" = "$repo" ] && rest=""
case "$repotype" in
http|https|ftp|nfs|nfs4|nfsiso)
set_neednet; root="anaconda-net:$repo" ;;
--
1.7.7.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 05-04-2012, 06:38 PM
"Brian C. Lane"
 
Default dracut: fix "repo=cdrom" (also kickstart with "cdrom")

On Fri, May 04, 2012 at 01:33:45PM -0400, Will Woods wrote:
> The replacement hack for splitsep wasn't detecting the case where the
> repo is just "cdrom" - no ":PATH" at the end - and trying to remove the
> "cdrom:" from the front of "cdrom", which doesn't work.
>
> In that case, we'll end up with $rest = $repo, so check for that, and
> set rest="".
> ---
> dracut/parse-anaconda-repo.sh | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/dracut/parse-anaconda-repo.sh b/dracut/parse-anaconda-repo.sh
> index 1e23c36..59bf7b5 100755
> --- a/dracut/parse-anaconda-repo.sh
> +++ b/dracut/parse-anaconda-repo.sh
> @@ -13,7 +13,8 @@ arg="repo"
>
> if [ -n "$repo" ]; then
> #splitsep ":" "$repo" repotype rest # FIXME: splitsep is buggy
> - repotype=${repo%%:*}; rest=${repo#$repotype:}
> + repotype=${repo%%:*}
> + rest=${repo#$repotype:}; [ "$rest" = "$repo" ] && rest=""
> case "$repotype" in
> http|https|ftp|nfs|nfs4|nfsiso)
> set_neednet; root="anaconda-net:$repo" ;;
> --
> 1.7.7.6

Ack.

--
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 01:23 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org