FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Development

 
 
LinkBack Thread Tools
 
Old 03-10-2010, 08:39 PM
"Daniel J Griffiths (Ghost1227)"
 
Default mv errors on some packages, switch to rsync

On 03/10/10 at 04:33pm, Daenyth Blank wrote:
> What errors? What packages? Why is the error occuring? This is not
> really a useful commit message...
>
> On Wed, Mar 10, 2010 at 16:31, Ghost1227 <ghost1227@archlinux.us> wrote:
> > ---
> > *makechrootpkg | * *4 ++--
> > *1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/makechrootpkg b/makechrootpkg
> > index c1e78d9..fa28fa5 100755
> > --- a/makechrootpkg
> > +++ b/makechrootpkg
> > @@ -232,9 +232,9 @@ fi
> > *for f in "${copydir}"/srcdest/*; do
> > * * * *[ -e "$f" ] || continue
> > * * * *if [ -d "$SRCDEST" ]; then
> > - * * * * * * * mv "$f" "${SRCDEST}"
> > + * * * * * * * rsync -qr "$f" "${SRCDEST}"
> > * * * *else
> > - * * * * * * * mv "$f" "${WORKDIR}"
> > + * * * * * * * rsync -qr "$f" "${WORKDIR}"
> > * * * *fi
> > *done
> >
> > --
> > 1.7.0.2
> >
> >
> >
> >
Hmm... my apologies, I kinda rushed this due to getting a call in the middle of the
commit (i'm at work right now). Some packages (notably vim) end up with folders in the
source tree that are included in the mv statement. if multiple rebuilds are made (ie;
you have to update a mistake in a build, fix an md5sum, edit a patch, etc and rebuild)
the folder already exists in $SRCDEST/$WORKDIR and as a result mv fails (mv can't move
a directory to a location containing a directory of the same name).
--
 

Thread Tools




All times are GMT. The time now is 06:21 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org