FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Development

 
 
LinkBack Thread Tools
 
Old 01-24-2010, 09:37 AM
Hans de Goede
 
Default Give MD BIOS RAID arrays there own type

Before the whole disk formatting changes MD BIOS RAID arrays used to have
their own type of "partitionable mdarray". And we check for the normal
"mdarray" type in various places (mostly to do with mdraid /boot handling where
I'm seeing a traceback qtm), and when the type matches mdarray the code
assumes a regular mdarray.

So this code restores MD BIOS RAID arrays having their own type, so as to
not trigger all these checks meant for regular mdraid arrays.
---
storage/__init__.py | 2 +-
storage/devices.py | 1 +
2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/storage/__init__.py b/storage/__init__.py
index 5ab8399..adb9f81 100644
--- a/storage/__init__.py
+++ b/storage/__init__.py
@@ -2122,7 +2122,7 @@ class FSSet(object):
""" Return the contents of mdadm.conf. """
retval = None
arrays = self.devicetree.getDevicesByType("mdarray")
- arrays.extend(self.devicetree.getDevicesByType("pa rtitionable mdarray"))
+ arrays.extend(self.devicetree.getDevicesByType("md biosraidarray"))
arrays.extend(self.devicetree.getDevicesByType("md container"))
# Sort it, this not only looks nicer, but this will also put
# containers (which get md0, md1, etc.) before their members
diff --git a/storage/devices.py b/storage/devices.py
index 5852352..f2ff639 100644
--- a/storage/devices.py
+++ b/storage/devices.py
@@ -2384,6 +2384,7 @@ class MDRaidArrayDevice(StorageDevice):
# when teared down.
if self.parents and self.parents[0].type == "mdcontainer":
self._size = self.currentSize
+ self._type = "mdbiosraidarray"

# FIXME: Bitmap is more complicated than this.
# It can be internal or external. External requires a filename.
--
1.6.5.2

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-25-2010, 07:48 AM
Ales Kozumplik
 
Default Give MD BIOS RAID arrays there own type

On 01/24/2010 11:37 AM, Hans de Goede wrote:

Before the whole disk formatting changes MD BIOS RAID arrays used to have
their own type of "partitionable mdarray". And we check for the normal
"mdarray" type in various places (mostly to do with mdraid /boot handling where
I'm seeing a traceback qtm), and when the type matches mdarray the code
assumes a regular mdarray.


Wasn't there a legitimate to have 'partitionable mdarray' removed?

Otherwise ACK from me.

Ales

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-25-2010, 08:05 AM
Hans de Goede
 
Default Give MD BIOS RAID arrays there own type

Hi,

On 01/25/2010 09:48 AM, Ales Kozumplik wrote:

On 01/24/2010 11:37 AM, Hans de Goede wrote:

Before the whole disk formatting changes MD BIOS RAID arrays used to have
their own type of "partitionable mdarray". And we check for the normal
"mdarray" type in various places (mostly to do with mdraid /boot
handling where
I'm seeing a traceback qtm), and when the type matches mdarray the code
assumes a regular mdarray.


Wasn't there a legitimate to have 'partitionable mdarray' removed?



It uses to be a separate class doing dual inheritance from both MDRaidDevice
and DiskDevice, as in the past you had to inherit from DiskDevice to be
considered partitionable by the partition code.

That is what rightly has been killed, it also having a separate type was
a side effect of it being in its own Class, but that is something which was
good to have, so this patch restores the separate type (as in the type attribute
string is different).

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-25-2010, 03:00 PM
Ales Kozumplik
 
Default Give MD BIOS RAID arrays there own type

It uses to be a separate class doing dual inheritance from both
MDRaidDevice
and DiskDevice, as in the past you had to inherit from DiskDevice to be
considered partitionable by the partition code.

That is what rightly has been killed, it also having a separate type was
a side effect of it being in its own Class, but that is something which was
good to have, so this patch restores the separate type (as in the type
attribute
string is different).



Thanks, that was the missing piece for me.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-25-2010, 04:14 PM
David Lehman
 
Default Give MD BIOS RAID arrays there own type

On Mon, 2010-01-25 at 09:48 +0100, Ales Kozumplik wrote:
> On 01/24/2010 11:37 AM, Hans de Goede wrote:
> > Before the whole disk formatting changes MD BIOS RAID arrays used to have
> > their own type of "partitionable mdarray". And we check for the normal
> > "mdarray" type in various places (mostly to do with mdraid /boot handling where
> > I'm seeing a traceback qtm), and when the type matches mdarray the code
> > assumes a regular mdarray.

This is getting out of hand. I'm starting to think that biosraid and
containers need their own subclasses.

Dave

>
> Wasn't there a legitimate to have 'partitionable mdarray' removed?
>
> Otherwise ACK from me.
>
> Ales
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@redhat.com
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 06:53 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org