FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Development

 
 
LinkBack Thread Tools
 
Old 01-04-2010, 02:38 PM
Martin Sivak
 
Default Review process and tools

Hi,

as you know, we need to improve our patch review process. With increasing volume are emails in mailinglists too cumbersome and hard to follow.

So we took a look on available solutions, excluding stuff which didn't seem finished, usable or (as mentioned before) using bugzilla as backend. And we found one project which looks promising:

- MIT license (free for commercial use)
- git (plain or over ssh) support
- script based patch posting (web based too of course)
- support for multiple patch versions
- per line comments
- multiple repos support
- usuall two panel patch view (before and after)
- list of users include Alcatel, Motorola, EA, Cisco, VMware, Yahoo
- list of projects include Asterisk, KOffice, ...

- programmed in Python/Django for which we have people who understand it

So If you find this interesting, just take a look at http://www.reviewboard.org. They even have an online demo accessible from their website. We lokked through the demo together with Ales and we thing it is pretty neat and doesn't introduce any new processes which would make it complicated to use.

--
Martin Sivak
Anaconda team / Brno, CZ

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-05-2010, 05:24 PM
Chris Lumens
 
Default Review process and tools

> - MIT license (free for commercial use)
> - git (plain or over ssh) support
> - script based patch posting (web based too of course)
> - support for multiple patch versions
> - per line comments
> - multiple repos support
> - usuall two panel patch view (before and after)
> - list of users include Alcatel, Motorola, EA, Cisco, VMware, Yahoo
> - list of projects include Asterisk, KOffice, ...
>
> - programmed in Python/Django for which we have people who understand it
>
> So If you find this interesting, just take a look at
> http://www.reviewboard.org. They even have an online demo accessible
> from their website. We lokked through the demo together with Ales and
> we thing it is pretty neat and doesn't introduce any new processes
> which would make it complicated to use.

It does look interesting. I need to play with it a bit to see how I
really feel about it, though.

Do you know of any other similar programs I could look at to do a
comparison?

Also, do you know if Fedora Infrastructure is thinking about putting
this (or any other similar) program into place distribution-wide? It
would be really excellent if they were because then we could take
advantage of the existing servers and login features. If not, maybe we
need to start trying to nudge them in that direction.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-05-2010, 05:43 PM
Bill Nottingham
 
Default Review process and tools

Chris Lumens (clumens@redhat.com) said:
> It does look interesting. I need to play with it a bit to see how I
> really feel about it, though.

There's also http://blog.fishsoup.net/2009/09/23/splinter-patch-review/,
but that might be more small-scale.

> Do you know of any other similar programs I could look at to do a
> comparison?
>
> Also, do you know if Fedora Infrastructure is thinking about putting
> this (or any other similar) program into place distribution-wide?

https://fedorahosted.org/fedora-infrastructure/ticket/1196

Bill

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-06-2010, 02:53 PM
Jon Masters
 
Default Review process and tools

On Tue, 2010-01-05 at 13:24 -0500, Chris Lumens wrote:
> > - MIT license (free for commercial use)
> > - git (plain or over ssh) support
> > - script based patch posting (web based too of course)
> > - support for multiple patch versions
> > - per line comments
> > - multiple repos support
> > - usuall two panel patch view (before and after)
> > - list of users include Alcatel, Motorola, EA, Cisco, VMware, Yahoo
> > - list of projects include Asterisk, KOffice, ...
> >
> > - programmed in Python/Django for which we have people who understand it
> >
> > So If you find this interesting, just take a look at
> > http://www.reviewboard.org. They even have an online demo accessible
> > from their website. We lokked through the demo together with Ales and
> > we thing it is pretty neat and doesn't introduce any new processes
> > which would make it complicated to use.
>
> It does look interesting. I need to play with it a bit to see how I
> really feel about it, though.

I looked at it earlier too. I know I'm not an Anaconda developer, but it
seems really cool, and useful for other RH projects. I especially like
the ability to select and comment on chunks of diffs, etc.

Jon.


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 01-06-2010, 03:37 PM
Chris Lumens
 
Default Review process and tools

> > Do you know of any other similar programs I could look at to do a
> > comparison?
> >
> > Also, do you know if Fedora Infrastructure is thinking about putting
> > this (or any other similar) program into place distribution-wide?
>
> https://fedorahosted.org/fedora-infrastructure/ticket/1196

Great, then we should not work no setting up anything ourselves and
instead wait to see what happens here.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 11:40 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org