FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Development

 
 
LinkBack Thread Tools
 
Old 12-23-2009, 02:42 PM
Ales Kozumplik
 
Default Avoid duplicate kernel cmdline options and cleanup booty dracut code

On 12/22/2009 09:43 PM, Hans de Goede wrote:

+ args.append(d.dracutSetupString())
+ import storage
+ if isinstance(d, storage.devices.NetworkStorageDevice):
+ args.append(self.id.network.dracutSetupString(d))


Is there a reason to have 'import storage' here and not at the top of
the file?


_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 12-23-2009, 03:34 PM
Hans de Goede
 
Default Avoid duplicate kernel cmdline options and cleanup booty dracut code

Hi,

On 12/23/2009 04:47 PM, Ales Kozumplik wrote:

- return args + self.appendArgs
+ if not root.dependsOn(d):
+ continue
+
+ args.append(d.dracutSetupString())

Is situation when a parent itself depends on something also handled?



Yes, dependsOn does recursive dependency checking.

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 12-23-2009, 03:36 PM
Hans de Goede
 
Default Avoid duplicate kernel cmdline options and cleanup booty dracut code

Hi,

On 12/23/2009 04:42 PM, Ales Kozumplik wrote:

On 12/22/2009 09:43 PM, Hans de Goede wrote:

+ args.append(d.dracutSetupString())
+ import storage
+ if isinstance(d, storage.devices.NetworkStorageDevice):
+ args.append(self.id.network.dracutSetupString(d))


Is there a reason to have 'import storage' here and not at the top of
the file?



Yes, this avoid an import loop

Regards,

Hans

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 10:03 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org