FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Development

 
 
LinkBack Thread Tools
 
Old 10-28-2009, 12:39 PM
Xavier
 
Default Change loop var CARCH to _arch

On Wed, Oct 21, 2009 at 9:20 AM, Francois Charette
<francois@archlinux.org> wrote:
> This is just better practice, as CARCH means something else in
> makepkg.conf
> ---
> *commitpkg | * *8 ++++----
> *1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/commitpkg b/commitpkg
> index e805b47..10f58d9 100755
> --- a/commitpkg
> +++ b/commitpkg
> @@ -67,10 +67,10 @@ if [ "$1" = "-l" ]; then
> * * shift 2
> *fi
>
> -for CARCH in ${arch[@]}; do
> - * *echo "===> Uploading to staging/$repo for arch=$CARCH"
> +for _arch in ${arch[@]}; do
> + * *echo "===> Uploading to staging/$repo for arch=${_arch}"
> * * for _pkgname in ${pkgname[@]}; do
> - * * * *pkgfile=$_pkgname-$pkgver-$pkgrel-$CARCH$PKGEXT
> + * * * *pkgfile=$_pkgname-$pkgver-$pkgrel-${_arch}$PKGEXT
>
> * * * * if [ ! -f $pkgfile -a -f "$PKGDEST/$pkgfile" ]; then
> * * * * * * pkgfile="$PKGDEST/$pkgfile"
> @@ -105,7 +105,7 @@ for CARCH in ${arch[@]}; do
> * * * * echo "===> Commited"
> * * fi
>
> - * *archrelease $repo-$CARCH || abort
> + * *archrelease $repo-${_arch} || abort
> *done
>
> *if [ "${arch[*]}" == "any" ]; then
> --
> 1.6.5
>
>

Not a big deal but I thought _arch was not a good practice either
because it could be defined in the pkgbuild.
Why not local_arch ?
 

Thread Tools




All times are GMT. The time now is 05:58 AM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org