FAQ Search Today's Posts Mark Forums Read
» Video Reviews

» Linux Archive

Linux-archive is a website aiming to archive linux email lists and to make them easily accessible for linux users/developers.


» Sponsor

» Partners

» Sponsor

Go Back   Linux Archive > ArchLinux > ArchLinux Development

 
 
LinkBack Thread Tools
 
Old 03-21-2009, 02:53 AM
David Lehman
 
Default Fix traceback in FSSet.crypttab. (#491160)

---
storage/__init__.py | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/storage/__init__.py b/storage/__init__.py
index fdb8c91..7040104 100644
--- a/storage/__init__.py
+++ b/storage/__init__.py
@@ -1591,7 +1591,8 @@ class FSSet(object):
devices = self.mountpoints.values() + self.swapDevices

# prune crypttab -- only mappings required by one or more entries
- for name in self.cryptTab.mappings:
+ names = self.cryptTab.mappings.keys()
+ for name in names:
keep = False
mapInfo = self.cryptTab[name]
cryptoDev = mapInfo['device']
--
1.6.0.6

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-21-2009, 02:55 AM
David Cantrell
 
Default Fix traceback in FSSet.crypttab. (#491160)

Looks fine, some comments below.

On 03/20/2009 05:53 PM, David Lehman wrote:

---
storage/__init__.py | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/storage/__init__.py b/storage/__init__.py
index fdb8c91..7040104 100644
--- a/storage/__init__.py
+++ b/storage/__init__.py
@@ -1591,7 +1591,8 @@ class FSSet(object):
devices = self.mountpoints.values() + self.swapDevices

# prune crypttab -- only mappings required by one or more entries
- for name in self.cryptTab.mappings:
+ names = self.cryptTab.mappings.keys()
+ for name in names:


I don't really have a problem with this, but why not:

for name in self.cryptTab.mappings.keys():


keep = False
mapInfo = self.cryptTab[name]
cryptoDev = mapInfo['device']



--
David Cantrell <dcantrell@redhat.com>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-21-2009, 02:57 AM
David Lehman
 
Default Fix traceback in FSSet.crypttab. (#491160)

> > diff --git a/storage/__init__.py b/storage/__init__.py
> > index fdb8c91..7040104 100644
> > --- a/storage/__init__.py
> > +++ b/storage/__init__.py
> > @@ -1591,7 +1591,8 @@ class FSSet(object):
> > devices = self.mountpoints.values() + self.swapDevices
> >
> > # prune crypttab -- only mappings required by one or more entries
> > - for name in self.cryptTab.mappings:
> > + names = self.cryptTab.mappings.keys()
> > + for name in names:
>
> I don't really have a problem with this, but why not:
>
> for name in self.cryptTab.mappings.keys():

You're right. I'll go with that.

>
> > keep = False
> > mapInfo = self.cryptTab[name]
> > cryptoDev = mapInfo['device']
>
>

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 
Old 03-21-2009, 02:59 AM
David Cantrell
 
Default Fix traceback in FSSet.crypttab. (#491160)

On 03/20/2009 05:57 PM, David Lehman wrote:

diff --git a/storage/__init__.py b/storage/__init__.py
index fdb8c91..7040104 100644
--- a/storage/__init__.py
+++ b/storage/__init__.py
@@ -1591,7 +1591,8 @@ class FSSet(object):
devices = self.mountpoints.values() + self.swapDevices

# prune crypttab -- only mappings required by one or more entries
- for name in self.cryptTab.mappings:
+ names = self.cryptTab.mappings.keys()
+ for name in names:

I don't really have a problem with this, but why not:

for name in self.cryptTab.mappings.keys():


You're right. I'll go with that.


Sounds good.




keep = False
mapInfo = self.cryptTab[name]
cryptoDev = mapInfo['device']




_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list



--
David Cantrell <dcantrell@redhat.com>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@redhat.com
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
 

Thread Tools




All times are GMT. The time now is 10:14 PM.

VBulletin, Copyright ©2000 - 2014, Jelsoft Enterprises Ltd.
Content Relevant URLs by vBSEO ©2007, Crawlability, Inc.
Copyright 2007 - 2008, www.linux-archive.org